Update babel/polyfill to 7.4.4#1521
Merged
bookernath merged 1 commit intobigcommerce:masterfrom Jun 27, 2019
bookernath:babel-7.4.4
Merged
Update babel/polyfill to 7.4.4#1521bookernath merged 1 commit intobigcommerce:masterfrom bookernath:babel-7.4.4
bookernath merged 1 commit intobigcommerce:masterfrom
bookernath:babel-7.4.4
Conversation
Contributor
|
@bookernath This should be fine, but I'm concerned about the large diff in package-lock.json. Can you do this again, following the procedure outlined in the readme? We should keep the version of Node and npm consistent to minimize the diff. |
junedkazi
reviewed
Jun 25, 2019
junedkazi
approved these changes
Jun 25, 2019
Contributor
junedkazi
left a comment
junedkazi
left a comment
There was a problem hiding this comment.
We might have to regenerate the lock after cornerstone release unless we plan on merging this PR and creating rc2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update babel/polyfill to latest, as it's 6 months out of date.
Next, we'll need to replace it: https://babeljs.io/docs/en/babel-polyfill