STRF-3591 add return instructions in return-saved.html #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
suggested changes
Jun 23, 2019
Contributor
bookernath
left a comment
bookernath
left a comment
There was a problem hiding this comment.
Looks good overall, just need to make sure language is in a language file and add a changelog.
Thanks!
bc-williamkwon
changed the title
bc-williamkwon
force-pushed
the
returnInstructions
branch
3 times, most recently
from
c8442a8 to
ca28fc0
Compare
bookernath
previously approved these changes
Jun 24, 2019
bc-williamkwon
force-pushed
the
returnInstructions
branch
4 times, most recently
from
d9de54c to
54b32e9
Compare
bookernath
previously approved these changes
Jun 27, 2019
Contributor
bookernath
left a comment
bookernath
left a comment
There was a problem hiding this comment.
Please rebase - otherwise this is good to go.
bc-williamkwon
force-pushed
the
returnInstructions
branch
3 times, most recently
from
2cb8a03 to
60fc8ad
Compare
mattolson
previously approved these changes
Jun 28, 2019
Contributor
mattolson
left a comment
mattolson
left a comment
There was a problem hiding this comment.
Looks good, but needs rebase
bc-williamkwon
force-pushed
the
returnInstructions
branch
from
60fc8ad to
2cb1cb9
Compare
bc-williamkwon
force-pushed
the
returnInstructions
branch
from
2cb1cb9 to
4779017
Compare
Contributor
Author
|
rebased. |
bookernath
approved these changes
Jun 28, 2019
junedkazi
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Previously return instructions did not appear after submitting a return request and one would need to edit the template file in return-saved.html to display return instructions even if they had configured returns instructions in the control panel. This pull request is to fix that issue.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.
