STRF-5665 remove google plus#1526
Merged
Merged
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-williamkwon
changed the title
bc-williamkwon
force-pushed
the
deprecateGoogle
branch
from
bd8b01d to
4694bb5
Compare
bookernath
previously approved these changes
Jun 25, 2019
junedkazi
previously approved these changes
Jun 25, 2019
mattolson
suggested changes
Jun 28, 2019
Contributor
mattolson
left a comment
mattolson
left a comment
There was a problem hiding this comment.
Can you update the changelog to say "Remove Google Plus"? This is more than a deprecation, this is a removal.
bc-williamkwon
changed the title
Contributor
|
@bc-williamkwon can you please rebase. |
bc-williamkwon
dismissed stale reviews from junedkazi and bookernath
via
a6b0b34
bc-williamkwon
force-pushed
the
deprecateGoogle
branch
2 times, most recently
from
a6b0b34 to
a64079a
Compare
Contributor
Author
|
Rebased. |
bc-williamkwon
force-pushed
the
deprecateGoogle
branch
from
a64079a to
bf702a1
Compare
mattolson
approved these changes
Jun 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Google plus is deprecated so we should remove it. This pull request is part of that that removal.
Tickets / Documentation