Skip to content

Conversation

@bookernath
Copy link
Contributor

What?

This variable does not return anything, so it should not be here.

There is no head.rsslinks in the context.

Tickets / Documentation

@bigbot
Copy link

bigbot commented Jul 17, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@bookernath
Copy link
Contributor Author

ping @bigcommerce/storefront-team

This variable does not return anything, so it should not be here.
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bookernath
Copy link
Contributor Author

@junedkazi some of those things still work, and some of them don't. We can take them one at a time.

I have high confidence in the change within this PR, because as far as I can tell, this variable has never done anything.

@bookernath bookernath merged commit eb04a8d into bigcommerce:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants