Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storefront): STRF-7084 remove RSS links from head #1539

Merged
merged 1 commit into from
Jul 19, 2019
Merged

chore(storefront): STRF-7084 remove RSS links from head #1539

merged 1 commit into from
Jul 19, 2019

Conversation

bookernath
Copy link
Contributor

What?

This variable does not return anything, so it should not be here.

There is no head.rsslinks in the context.

Tickets / Documentation

@bigbot
Copy link

bigbot commented Jul 17, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@bookernath
Copy link
Contributor Author

ping @bigcommerce/storefront-team

This variable does not return anything, so it should not be here.
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bookernath
Copy link
Contributor Author

@junedkazi some of those things still work, and some of them don't. We can take them one at a time.

I have high confidence in the change within this PR, because as far as I can tell, this variable has never done anything.

@bookernath bookernath merged commit eb04a8d into bigcommerce:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants