feat(storefront): STRF-4418 allow alert text color editing from theme editor and update default alert text color for Bold variation#1565
Merged
Conversation
Contributor
|
@bc-NikitaPuzanenko please add a changelog - this looks good otherwise. |
bc-NikitaPuzanenko
force-pushed
the
STRF-4418
branch
from
a19e738 to
9eae59c
Compare
junedkazi
reviewed
Sep 6, 2019
| "id": "alert-backgroundColor" | ||
| }, | ||
| { | ||
| "type": "color", |
bc-NikitaPuzanenko
force-pushed
the
STRF-4418
branch
from
9eae59c to
2f3fce8
Compare
… editor and update default alert text color for Bold variation
bc-NikitaPuzanenko
force-pushed
the
STRF-4418
branch
from
2e36c26 to
a457834
Compare
Contributor
|
@bigcommerce/merc-team @bigcommerce/storefront-team can someone take a look at this for Nikita? |
christensenep
approved these changes
Jan 9, 2020
Contributor
christensenep
left a comment
christensenep
left a comment
There was a problem hiding this comment.
Ran this by design, and LGTM 👍
bookernath
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Cornerstone bold uses #ffffff(white) for the alert box text color, this makes it very hard to see. This ticket changes the default Cornerstone bold alert text color to #333333 and makes the text color editable from the theme-editor
Tickets / Documentation
Screenshots (if appropriate)
Before:
After:
