Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-7334 - Fix image sizing on review modal #1592

Merged

Conversation

@bookernath
Copy link
Contributor

bookernath commented Nov 5, 2019

What?

Update the review modal image styling to make sure the image shows full-width.

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Before:

image

After:

image

@bigbot

This comment has been minimized.

Copy link

bigbot commented Nov 5, 2019

@bookernath bookernath force-pushed the bookernath:review-modal-image-styling branch from 6f57ad4 to e6f71e1 Nov 5, 2019
@bookernath bookernath changed the title Fix image sizing on review modal STRF-7334 - Fix image sizing on review modal Nov 5, 2019
@junedkazi

This comment has been minimized.

Copy link
Contributor

junedkazi commented Nov 5, 2019

@bookernath we don't have an after image.

@bookernath bookernath force-pushed the bookernath:review-modal-image-styling branch from e6f71e1 to 65be3d9 Nov 5, 2019
@bookernath bookernath requested a review from junedkazi Nov 5, 2019
@bookernath bookernath force-pushed the bookernath:review-modal-image-styling branch from 65be3d9 to b5b60ed Nov 5, 2019
@bookernath bookernath merged commit e038d3b into bigcommerce:master Nov 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bookernath bookernath deleted the bookernath:review-modal-image-styling branch Nov 5, 2019
@bookernath bookernath restored the bookernath:review-modal-image-styling branch Nov 7, 2019
@bookernath bookernath deleted the bookernath:review-modal-image-styling branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.