STRF-7604 - Fix remaining itemprop availability tag for pricing #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-jz
force-pushed
the
STRF-7604
branch
3 times, most recently
from
c93efd1
to
d91f8b8
Compare
…tax case in price.html component.
megdesko
approved these changes
Nov 25, 2019
sandeepgraju
approved these changes
Nov 25, 2019
ncheikh
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes
itempropavailability meta tag for price including tax case in price.html component. This is to address theavailabilitynot being set in a Google Structured Data test on PDP only when price is including tax.This was missed in updates on STRF-6450.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-7604
Screenshots (if appropriate)
master - This is the google structured data test with store set to display prices including taxes on PDP:
On my branch - This is the same PDP test for prices including tax:
