Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translate) TRANS-650 added SchemaTranslations.json for cornerstone #1644

Merged
merged 4 commits into from Mar 24, 2020

Conversation

phanyaa
Copy link
Contributor

@phanyaa phanyaa commented Feb 27, 2020

What?

Added a .json file that contains translations for the Cornerstone theme.

@phanyaa phanyaa changed the title feat(translate) TRANS-650 added SchemaTranslations.json for cornerstone (WIP)feat(translate) TRANS-650 added SchemaTranslations.json for cornerstone Feb 27, 2020
@phanyaa phanyaa changed the title (WIP)feat(translate) TRANS-650 added SchemaTranslations.json for cornerstone feat(translate) TRANS-650 added SchemaTranslations.json for cornerstone Mar 4, 2020
@phanyaa
Copy link
Contributor Author

phanyaa commented Mar 6, 2020

@pedelman @BC-EChristensen @junedkazi @bc-williamkwon guys, could you please review it?

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @bigcommerce/merc-team for visibility

@christensenep christensenep merged commit 7e384a0 into bigcommerce:master Mar 24, 2020
@VisionsDeveloper
Copy link

Hi Guys,

We are facing a validation issue due to SchemaTranslations.json file, When we are updating any theme from the older version to a new version of the cornerstone and it does not allow us to create a bundle and push the theme code in-store. Can we remove this file? please share your thoughts.

Thanks,
VD

@BC-tymurbiedukhin
Copy link
Contributor

Hello, could you please provide some additional info and screenshots with bundle error? @VisionsDeveloper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants