fix(catalog): CATALOG-5557 Special characters are not rendered for product review #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
reviewed
Apr 30, 2020
| @@ -35,7 +35,7 @@ <h5 itemprop="name" class="productReview-title">{{ title }}</h5> | |||
| </p> | |||
| {{/if}} | |||
| </header> | |||
| <p itemprop="reviewBody" class="productReview-body">{{nl2br text}}</p> | |||
| <p itemprop="reviewBody" class="productReview-body">{{{ sanitize text }}}</p> | |||
There was a problem hiding this comment.
can we please do the same for the review title as well
There was a problem hiding this comment.
Sure. I've done the same for the review title.
There was a problem hiding this comment.
The same issue is also present on facets
junedkazi
approved these changes
May 4, 2020
|
💚 |
|
This doesn't work for me, if I add the new line and remove the old one my reviews no longer paragraph properly and instead show as big chunks of text with no breaks. Yes it removed the weird special characters ' cause, but the paragraph breaks are gone. Am I doing something wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special characters are not rendered for product review titles and text on storefront
What?
Special characters in product review titles and texts are displaying html entities. The entities that are occurring are generally for single quotes and ampersand.
Tickets / Documentation
Add links to any relevant tickets and documentation.
https://jira.bigcommerce.com/browse/CATALOG-5557
Screenshots