fix(bctheme): BCTHEME-20 Stencil Themes - Non-required options do not… #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have a 'none' choice on the storefront
|
Autotagging @bigcommerce/storefront-team @davidchin |
golcinho
reviewed
Jul 9, 2020
golcinho
reviewed
Jul 9, 2020
junedkazi
suggested changes
Jul 13, 2020
|
|
||
| try { | ||
| for (const [key, val] of formData) { | ||
| if (!(val instanceof File) || val.name || val.size) { |
There was a problem hiding this comment.
why loop through the same form data again. Can we just merge this check into the above method definition.
There was a problem hiding this comment.
This is util function which can be used by its own because I believe sending empty values not only issue for product options fields
| * @returns FormData object | ||
| */ | ||
| export const filterEmptyValuesFromForm = formData => { | ||
| const res = new FormData(); |
There was a problem hiding this comment.
Any reason to create a new formData ? since the incoming formData is already of the type FormData
There was a problem hiding this comment.
This is pure function which makes result of executing predictable and easy testable. I have faced some issues with changing form data by link so decided to make it in this way
junedkazi
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… have a 'none' choice on the storefront
What?
Historically, when product options were set to not required a shopper would have the ability to select 'none' on the option. Stencil themes not provide this choice, so if a shopper selects an option that isn't required, they do not have the ability to de-select it by choosing 'none'. This can be frustrating for shoppers, especially when there are price change rules attached to the non-required option.
Tickets / Documentation
https://jira.bigcommerce.com/browse/BCTHEME-20
Screenshots (if appropriate)
ping @yurytut1993 @golcinho @junedkazi