feat(payment): PAYPAL-968 added banner widgets to page builder#2021
Merged
BC-tymurbiedukhin merged 2 commits intobigcommerce:masterfrom Apr 30, 2021
Merged
feat(payment): PAYPAL-968 added banner widgets to page builder#2021BC-tymurbiedukhin merged 2 commits intobigcommerce:masterfrom
BC-tymurbiedukhin merged 2 commits intobigcommerce:masterfrom
Conversation
andriiVitvitskyi1990
force-pushed
the
PAYPAL-968
branch
6 times, most recently
from
efb6b9c to
2758a0e
Compare
bc-fetisov
reviewed
Apr 14, 2021
Contributor
bc-fetisov
left a comment
bc-fetisov
left a comment
There was a problem hiding this comment.
Please see comments, and add explanation message to popup, see updated description https://jira.bigcommerce.com/browse/PAYPAL-968
Message example:
schemaTranslations.json
Outdated
| "default": "White no border" | ||
| }, | ||
| "i18n.gray": { | ||
| "default": "gray" |
schemaTranslations.json
Outdated
| "default": "gray" | ||
| }, | ||
| "i18n.monochrome": { | ||
| "default": "monochrome" |
schemaTranslations.json
Outdated
| "default": "monochrome" | ||
| }, | ||
| "i18n.grayscale": { | ||
| "default": "grayscale" |
config.json
Outdated
| "paymentbuttons-paypal-fundingicons": false, | ||
| "paymentbanners-homepage-color": "white", | ||
| "paymentbanners-homepage-ratio": "8x1", | ||
| "paymentbanners-homepage-logo-type": "primary", |
Contributor
There was a problem hiding this comment.
paymentbanners-homepage-logo-type - not used
schema.json
Outdated
| }, | ||
| { | ||
| "value": "primary", | ||
| "label": "i18n.right" |
Contributor
There was a problem hiding this comment.
i18n.primary and add translation also please
andriiVitvitskyi1990
force-pushed
the
PAYPAL-968
branch
2 times, most recently
from
07e4868 to
e045700
Compare
bc-fetisov
reviewed
Apr 16, 2021
schemaTranslations.json
Outdated
| "default": "Payment Banners" | ||
| }, | ||
| "i18n.CartPageBanner": { | ||
| "default": "Cart Page Banner" |
Contributor
There was a problem hiding this comment.
change first letters please ->Cart page banner
andriiVitvitskyi1990
force-pushed
the
PAYPAL-968
branch
from
e045700 to
31a94be
Compare
bc-fetisov
reviewed
Apr 19, 2021
schemaTranslations.json
Outdated
| "default": "None" | ||
| }, | ||
| "i18n.PaymentBanners": { | ||
| "default": "Payment banners" |
Contributor
There was a problem hiding this comment.
Payment banners > Payment Banners
bc-fetisov
reviewed
Apr 19, 2021
schema.json
Outdated
| "label": "i18n.inline" | ||
| }, | ||
| { | ||
| "value": "i18n.primary", |
andriiVitvitskyi1990
force-pushed
the
PAYPAL-968
branch
3 times, most recently
from
e2dc09a to
174d501
Compare
BC-ACherednichenko
approved these changes
Apr 20, 2021
bc-fetisov
approved these changes
Apr 26, 2021
Contributor
bc-fetisov
left a comment
bc-fetisov
left a comment
There was a problem hiding this comment.
LGTM. Please update change log only.
@BC-tymurbiedukhin @bc-alexsaiannyi could you approve this PR also?
BC-tymurbiedukhin
requested review from
BC-tymurbiedukhin,
bc-alexsaiannyi,
bc-azvierieva and
yurytut1993
andriiVitvitskyi1990
force-pushed
the
PAYPAL-968
branch
from
174d501 to
7ea8be1
Compare
andriiVitvitskyi1990
force-pushed
the
PAYPAL-968
branch
from
7ea8be1 to
99f32dd
Compare
Contributor
Author
|
bc-alexsaiannyi
approved these changes
Apr 29, 2021
yurytut1993
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added paypal banner widgets to page builder
Tickets / Documentation
Add links to any relevant tickets and documentation.
-https://jira.bigcommerce.com/browse/PAYPAL-968
Screenshots (if appropriate)