New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude assets/cdn from stencil bundle #240

Merged
merged 1 commit into from Nov 1, 2016

Conversation

Projects
None yet
4 participants
@dstaley
Contributor

dstaley commented Sep 12, 2016

This PR excludes the folder assets/cdn from the zip file created by running stencil bundle.

As a theme developer, I might want to include large assets that push the size of my theme's bundle past the 50MB mark. If I want to exclude my assets from the bundle, they'd need to be outside the assets directory. This results in the inability to use the stencil server to serve those assets. This change enables the theme developer to use a special folder, named cdn within their assets folder which is then excluded from the bundle.

This PR can stand on its own, but I think it makes a lot more sense in the context of my other PR (bigcommerce/paper#97), which enables theme developers to conditionally serve assets from the CDN folder when in a local environment, and from a third-party CDN when in production.

@lord2800

This comment has been minimized.

Show comment
Hide comment
@lord2800

lord2800 Oct 31, 2016

Contributor

Makes sense to me. @mcampa, can you think of any reason this shouldn't be merged?

Contributor

lord2800 commented Oct 31, 2016

Makes sense to me. @mcampa, can you think of any reason this shouldn't be merged?

@mcampa

This comment has been minimized.

Show comment
Hide comment
@mcampa

mcampa Nov 1, 2016

Contributor

👍

Contributor

mcampa commented Nov 1, 2016

👍

@mcampa mcampa merged commit 7c754ea into bigcommerce:master Nov 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment