Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize user.name property to be all lower-case #52

Closed
Marak opened this issue May 18, 2015 · 1 comment
Closed

Normalize user.name property to be all lower-case #52

Marak opened this issue May 18, 2015 · 1 comment
Labels
bug

Comments

@Marak
Copy link
Collaborator

Marak commented May 18, 2015

It looks like in the database the resource property user.name is not normalized to lowercase. This has probably also leaked into the owner property on other resources.

A quick migration script and a few lines of code should fix this.

The issue is that since a lot of our incoming requests are coming over HTTP, case-sensitivity can be a problem. Better to normalize all resources keys to be lower-case.
@Marak Marak added the bug label May 18, 2015
@Marak
Copy link
Collaborator Author

Marak commented Sep 9, 2015

This seems to be resolved with a06cbf3

Will need to run the migration script on production and all the names should be sorted.

Marak added a commit that referenced this issue Sep 11, 2015
@Marak
[api] [fix] Ensure lower-case owner and name #52
7015a4c 
 * Puts quick .toLowerCase() on all route params
 * Should cover all API calls
 * Should ensure backwards compatibility
@Marak Marak closed this as completed Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Marak