New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Jenkins JDK 8 changes into ./scripts/jenkins-test #1008

Closed
fnothaft opened this Issue Apr 21, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@fnothaft
Member

fnothaft commented Apr 21, 2016

See #989.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Apr 27, 2016

Member

What needs to be done here? I don't see anything JDK related except for the -XX:MaxPermSize=1g maven flag that might be deprecated on JDK8.

Member

heuermh commented Apr 27, 2016

What needs to be done here? I don't see anything JDK related except for the -XX:MaxPermSize=1g maven flag that might be deprecated on JDK8.

fnothaft added a commit to fnothaft/adam that referenced this issue Apr 28, 2016

[ADAM-1008] Modify jenkins-test script to support Java 8 build.
Resolves #1008. As per discussion with @shaneknapp, it is preferable to support
builds across Java versions by manually setting JAVA_HOME in a shell script run
inside of Jenkins. This is due to certain configuration limitations inside of
Jenkins. Currently, we are doing this via a script tracked inside of Jenkins.
I would rather roll all of that config into the ./scripts/jenkins-test script
so that we have revision control, etc.

fnothaft added a commit to fnothaft/adam that referenced this issue Apr 28, 2016

[ADAM-1008] Modify jenkins-test script to support Java 8 build.
Resolves #1008. As per discussion with @shaneknapp, it is preferable to support
builds across Java versions by manually setting JAVA_HOME in a shell script run
inside of Jenkins. This is due to certain configuration limitations inside of
Jenkins. Currently, we are doing this via a script tracked inside of Jenkins.
I would rather roll all of that config into the ./scripts/jenkins-test script
so that we have revision control, etc.

@heuermh heuermh modified the milestone: 0.20.0 Jun 5, 2016

@heuermh heuermh referenced this issue Jun 7, 2016

Closed

Release ADAM version 0.20.0 #1048

47 of 61 tasks complete

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 6, 2016

[ADAM-1008] Modify jenkins-test script to support Java 8 build.
Resolves #1008. As per discussion with @shaneknapp, it is preferable to support
builds across Java versions by manually setting JAVA_HOME in a shell script run
inside of Jenkins. This is due to certain configuration limitations inside of
Jenkins. Currently, we are doing this via a script tracked inside of Jenkins.
I would rather roll all of that config into the ./scripts/jenkins-test script
so that we have revision control, etc.

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 6, 2016

[ADAM-1008] Modify jenkins-test script to support Java 8 build.
Resolves #1008. As per discussion with @shaneknapp, it is preferable to support
builds across Java versions by manually setting JAVA_HOME in a shell script run
inside of Jenkins. This is due to certain configuration limitations inside of
Jenkins. Currently, we are doing this via a script tracked inside of Jenkins.
I would rather roll all of that config into the ./scripts/jenkins-test script
so that we have revision control, etc.

@heuermh heuermh closed this in #1026 Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment