Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant dbsnp rs id tracking in vcf2adam and ADAM2Vcf #1103

Closed
jpdna opened this issue Aug 7, 2016 · 5 comments
Closed

Variant dbsnp rs id tracking in vcf2adam and ADAM2Vcf #1103

jpdna opened this issue Aug 7, 2016 · 5 comments
Milestone

Comments

@jpdna
Copy link
Member

@jpdna jpdna commented Aug 7, 2016

Currently when running vcf2adam followed by adam2vcf the ID column in the original VCF file, commonly a dbSNP rs_id, is lost.

Looking at bdg-formats, I now realize that there is no ID field in Variant, and I am not sure where ID would be stored if we wanted to preserve it. One possibility is the attributes field of Variant Annotation. I'd tend to suggest that the ID field is so basic and practically useful to many users that there should be a nullable field for it in Variant. Or am I missing where ID is currently stored?

What do you think @heuermh and @fnothaft ?

@heuermh
Copy link
Member

@heuermh heuermh commented Aug 25, 2016

Fixed by #1131

@heuermh heuermh modified the milestone: 0.20.0 Sep 7, 2016
@heuermh heuermh mentioned this issue Sep 7, 2016
47 of 61 tasks complete
@heuermh heuermh modified the milestones: 0.20.0, 0.22.0, 0.21.0 Oct 13, 2016
@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 8, 2016

Should be resolved by #1250.

@heuermh
Copy link
Member

@heuermh heuermh commented Nov 11, 2016

Actually, this one was fixed earlier than #1250 by #1131 but won't show up on master until #1135 is merged.

@heuermh
Copy link
Member

@heuermh heuermh commented Nov 16, 2016

Fixed by #1131.

@heuermh heuermh closed this Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.