New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder kryo.register statements in ADAMKryoRegistrator #1146

Closed
heuermh opened this Issue Sep 1, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@heuermh
Member

heuermh commented Sep 1, 2016

I'd like to clean up ADAMKyroRegistrator by removing package imports, using fully qualified class names, and sorting alphabetically, with blank lines between packages. E.g.

// package org.bdgenomics.adam.models
kryo.register(classOf[org.bdgenomics.adam.models.Coverage], new AvroSerializer[org.bdgenomics.adam.models.Coverage])
kryo.register(classOf[org.bdgenomics.adam.models.ReferenceRegion], new AvroSerializer[org.bdgenomics.adam.models.ReferenceRegion])

// package org.bdgenomics.formats.avro
kryo.register(classOf[org.bdgenomics.formats.avro.AlignmentRecord], new AvroSerializer[org.bdgenomics.formats.avro.AlignmentRecord])
kryo.register(classOf[org.bdgenomics.formats.avro.Contig], new AvroSerializer[org.bdgenomics.formats.avro.Contig])

// package scala
kryo.register(classOf[scala.Array[org.bdgenomics.adam.models.Coverage]])
kryo.register(classOf[scala.Array[org.bdgenomics.adam.models.ReferenceRegion]])
kryo.register(classOf[scala.Array[org.bdgenomics.formats.avro.AlignmentRecord]])
kryo.register(classOf[scala.Array[org.bdgenomics.formats.avro.Contig]])

The way it is now is confusing and has resulted in missing and duplicated register statements.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 2, 2016

Member

I <3. +10000.

Seriously. This drives me batty as well.

Member

fnothaft commented Sep 2, 2016

I <3. +10000.

Seriously. This drives me batty as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment