Publish sources JAR with snapshots #1195

Closed
ryan-williams opened this Issue Oct 4, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@ryan-williams
Member

ryan-williams commented Oct 4, 2016

It would be nice to be able to navigate around the source from within projects that are depending on 0.19.1-SNAPSHOT.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 5, 2016

Member

As far as I know, there isn't any way to activate a profile only for deploy, so we would need to enable building source jars all the time. Fine with me, since we're already generating scaladocs at verify in the lifecycle, and that probably takes a lot longer than building source jars.

Or @fnothaft, do we run deploy with -Pdistribution from Jenkins?

Member

heuermh commented Oct 5, 2016

As far as I know, there isn't any way to activate a profile only for deploy, so we would need to enable building source jars all the time. Fine with me, since we're already generating scaladocs at verify in the lifecycle, and that probably takes a lot longer than building source jars.

Or @fnothaft, do we run deploy with -Pdistribution from Jenkins?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Oct 5, 2016

Member

We don't run the snapshot builds with -Pdistribution, but we should. I've changed that in Jenkins, and am running a build.

Member

fnothaft commented Oct 5, 2016

We don't run the snapshot builds with -Pdistribution, but we should. I've changed that in Jenkins, and am running a build.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 5, 2016

Member

Thanks, will see how that works. There is perhaps some cleanup that could be done, e.g. the scala-maven-plugin configuration in the distribution profile is nearly identical to that in <plugins>, and if we're running scaladoc in verify we should also be running javadoc at the same phase. I assume we do that to catch doc errors at build time?

Member

heuermh commented Oct 5, 2016

Thanks, will see how that works. There is perhaps some cleanup that could be done, e.g. the scala-maven-plugin configuration in the distribution profile is nearly identical to that in <plugins>, and if we're running scaladoc in verify we should also be running javadoc at the same phase. I assume we do that to catch doc errors at build time?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 5, 2016

Member

In the build logs I see the source jars being generated

[INFO] --- maven-source-plugin:2.4:jar-no-fork (attach-sources) @ adam-core-spark2_2.11
---
[INFO] Building jar:
/home/jenkins/workspace/ADAM/HADOOP_VERSION/2.3.0/
SCALAVER/2.11/SPARK_VERSION/2.0.0/label/centos/adam-core/
target/adam-core-spark2_2.11-0.19.1-SNAPSHOT-sources.jar

and I see the source jars (e.g. adam-core_2.10-0.19.1-20161005.153221-1380-sources.jar) in the Sonatype snapshot repository

https://oss.sonatype.org/content/repositories/snapshots/org/bdgenomics/adam/adam-core_2.10/0.19.1-SNAPSHOT/

Member

heuermh commented Oct 5, 2016

In the build logs I see the source jars being generated

[INFO] --- maven-source-plugin:2.4:jar-no-fork (attach-sources) @ adam-core-spark2_2.11
---
[INFO] Building jar:
/home/jenkins/workspace/ADAM/HADOOP_VERSION/2.3.0/
SCALAVER/2.11/SPARK_VERSION/2.0.0/label/centos/adam-core/
target/adam-core-spark2_2.11-0.19.1-SNAPSHOT-sources.jar

and I see the source jars (e.g. adam-core_2.10-0.19.1-20161005.153221-1380-sources.jar) in the Sonatype snapshot repository

https://oss.sonatype.org/content/repositories/snapshots/org/bdgenomics/adam/adam-core_2.10/0.19.1-SNAPSHOT/

@fnothaft fnothaft closed this Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment