Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Evaluate bdg-convert external conversion library proposal #1197
Generally looks OK to me. I'm +0. A variety of nits:
Thanks for the review.
There are more implementations here, including some with nested converters
For example, the
Other shared code could be extracted to (package) private static classes.
I proposed to write it in Java because I have found calling Java from Scala to be less troublesome than calling Scala from Java, and some potential clients of this library are implemented in Java (e.g. my stuff above, GATK4, UCSD's https://github.com/biojava/biojava-spark, etc.)
A dependency on our Scala models may answer the question though, and the separate repo question as well.
I don't like the package naming either. Suggestions are welcome.
We may be able to defer to the Avro companions to said models. E.g.,
What's the general goal of the present naming scheme? I would suggest something along the lines of
I get your point, and agree in spirit, but it's pretty hard to avoid public third party API dependencies in a library that converts to/from third party formats. ;)
While I don't care for the awkward package names, the current packaging is essential.
The only proper public API is in the
If packaging were done by recordname, then the module would have to refer to all the different third party classes, and there would be no extensibility.
bdg-convert version 0.1 was released to Maven Central on May 26 2017.