Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way for users to add VCF header lines #1233

Closed
fnothaft opened this issue Oct 29, 2016 · 0 comments
Closed

Need a way for users to add VCF header lines #1233

fnothaft opened this issue Oct 29, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Oct 29, 2016

I've kinda known this to be a problem for a while, but I was just using a VCF I saved with ADAM that had genotype filters (FT field) in a downstream tool, and I got an exception in the downstream tool because my VCF did not have a ##FILTER=<ID=ID,Description="description"> line in the header. I have a general idea for how to do this; will post next week for discussion when I'm not bandwidth limited. I think this approach would also work for SAM program fields, which would be a plus.

@fnothaft fnothaft added this to the 0.21.0 milestone Nov 11, 2016
@fnothaft fnothaft self-assigned this Nov 11, 2016
fnothaft added a commit to fnothaft/adam that referenced this issue Nov 11, 2016
Resolves bigdatagenomics#1233. Adds a `headerLines` field to all Variant-related GenomicRDDs.
In the current implementation, this field is populated by the set of all
header lines for all INFO/FORMAT fields that we support. In a future patch, we
will also store the header lines that correspond to fields that do not map to
a specific field in the Variant/Genotype schema, and that are stored in an
attribute map.
fnothaft added a commit to fnothaft/adam that referenced this issue Nov 18, 2016
Resolves bigdatagenomics#1233. Adds a `headerLines` field to all Variant-related GenomicRDDs.
In the current implementation, this field is populated by the set of all
header lines for all INFO/FORMAT fields that we support. In a future patch, we
will also store the header lines that correspond to fields that do not map to
a specific field in the Variant/Genotype schema, and that are stored in an
attribute map.
heuermh added a commit that referenced this issue Nov 18, 2016
Resolves #1233. Adds a `headerLines` field to all Variant-related GenomicRDDs.
In the current implementation, this field is populated by the set of all
header lines for all INFO/FORMAT fields that we support. In a future patch, we
will also store the header lines that correspond to fields that do not map to
a specific field in the Variant/Genotype schema, and that are stored in an
attribute map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.