Assembly jar doesn't get rebuilt on CLI changes #1238

Closed
fnothaft opened this Issue Nov 3, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@fnothaft
Member

fnothaft commented Nov 3, 2016

At least, this is what I'm seeing locally. I'm not exactly sure why this is, but it appears that the CLI jar gets rebuilt, but the shaded uberjar doesn't. @heuermh I've assigned this to you, because I think you're the best person to take this on.

@fnothaft fnothaft added the bug label Nov 3, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 4, 2016

Member

I'm not able to replicate this.

Making a change to ADAMMain.scala changes the file size of the uberjar

$ mvn install
$ ls -ls /Users/heuermh/.m2/repository/org/bdgenomics/adam/adam-assembly_2.10/0.20.1-SNAPSHOT/adam-assembly_2.10-0.20.1-SNAPSHOT.jar
42332825 Nov  4 06:12 adam-assembly_2.10-0.20.1-SNAPSHOT.jar

// make change, then
$ mvn install
$ ls -ls /Users/heuermh/.m2/repository/org/bdgenomics/adam/adam-assembly_2.10/0.20.1-SNAPSHOT/adam-assembly_2.10-0.20.1-SNAPSHOT.jar
42332833 Nov  4 06:20 adam-assembly_2.10-0.20.1-SNAPSHOT.jar
``
Member

heuermh commented Nov 4, 2016

I'm not able to replicate this.

Making a change to ADAMMain.scala changes the file size of the uberjar

$ mvn install
$ ls -ls /Users/heuermh/.m2/repository/org/bdgenomics/adam/adam-assembly_2.10/0.20.1-SNAPSHOT/adam-assembly_2.10-0.20.1-SNAPSHOT.jar
42332825 Nov  4 06:12 adam-assembly_2.10-0.20.1-SNAPSHOT.jar

// make change, then
$ mvn install
$ ls -ls /Users/heuermh/.m2/repository/org/bdgenomics/adam/adam-assembly_2.10/0.20.1-SNAPSHOT/adam-assembly_2.10-0.20.1-SNAPSHOT.jar
42332833 Nov  4 06:20 adam-assembly_2.10-0.20.1-SNAPSHOT.jar
``
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 4, 2016

Member

I will close this for now and reopen if I have this repro.

Member

fnothaft commented Nov 4, 2016

I will close this for now and reopen if I have this repro.

@fnothaft fnothaft closed this Nov 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment