Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add maven-source-plugin into the pom file #1239

Closed
Fei-Guang opened this issue Nov 4, 2016 · 3 comments
Closed

please add maven-source-plugin into the pom file #1239

Fei-Guang opened this issue Nov 4, 2016 · 3 comments

Comments

@Fei-Guang
Copy link

@Fei-Guang Fei-Guang commented Nov 4, 2016

currently , i copy all the source files manually then use jar to package the source jar
D:\adam-adam-parent-spark2_2.11-0.20.0>jar cvf adam-2.11-0.20 .0-sources.jar -C source/ .

please add maven-source-plugin into the pom file to package the source

@heuermh
Copy link
Member

@heuermh heuermh commented Nov 4, 2016

The maven-source-plugin is already included in the ADAM build.

To build on top of ADAM, I would suggest copying liberally from the project structure of either
https://github.com/heuermh/adam-examples
or
https://github.com/heuermh/adam-commands

The READMEs of both need an update for Spark 2.x and ADAM version 0.20.0, I'll do that and push shortly.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 5, 2016

OOC, are you depending on adam-parent instead of adam-{core, apis, cli}? adam-parent is a POM only dependency and should not be used.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 20, 2016

Closing as not a bug.

@fnothaft fnothaft closed this Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.