please add maven-source-plugin into the pom file #1239

Closed
Fei-Guang opened this Issue Nov 4, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@Fei-Guang

Fei-Guang commented Nov 4, 2016

currently , i copy all the source files manually then use jar to package the source jar
D:\adam-adam-parent-spark2_2.11-0.20.0>jar cvf adam-2.11-0.20 .0-sources.jar -C source/ .

please add maven-source-plugin into the pom file to package the source

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 4, 2016

Member

The maven-source-plugin is already included in the ADAM build.

To build on top of ADAM, I would suggest copying liberally from the project structure of either
https://github.com/heuermh/adam-examples
or
https://github.com/heuermh/adam-commands

The READMEs of both need an update for Spark 2.x and ADAM version 0.20.0, I'll do that and push shortly.

Member

heuermh commented Nov 4, 2016

The maven-source-plugin is already included in the ADAM build.

To build on top of ADAM, I would suggest copying liberally from the project structure of either
https://github.com/heuermh/adam-examples
or
https://github.com/heuermh/adam-commands

The READMEs of both need an update for Spark 2.x and ADAM version 0.20.0, I'll do that and push shortly.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 5, 2016

Member

OOC, are you depending on adam-parent instead of adam-{core, apis, cli}? adam-parent is a POM only dependency and should not be used.

Member

fnothaft commented Nov 5, 2016

OOC, are you depending on adam-parent instead of adam-{core, apis, cli}? adam-parent is a POM only dependency and should not be used.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Nov 20, 2016

Member

Closing as not a bug.

Member

fnothaft commented Nov 20, 2016

Closing as not a bug.

@fnothaft fnothaft closed this Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment