Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAM minor release to support htsjdk 2.7.0? #1248

Closed
lbergelson opened this issue Nov 7, 2016 · 6 comments
Closed

ADAM minor release to support htsjdk 2.7.0? #1248

lbergelson opened this issue Nov 7, 2016 · 6 comments
Milestone

Comments

@lbergelson
Copy link
Contributor

@lbergelson lbergelson commented Nov 7, 2016

GATK4 depends on ADAM, this allows us to support reading from ADAM datafiles. We've recently run into an issue where htsjdk 2.7.0 removed some deprecated classes that ADAM was using. Would be possible to do a minor release of ADAM that incorporates the patch that removes those classes?

I don't know what the release process is like, so if it's a pain to do a minor release we can work around it by either publishing our own snapshot or temporarily disabling support until the next full release.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 7, 2016

Hi @lbergelson! We are planning to do our next major release towards the end of this month, but if that timeline would be a bit long for you, we could probably push a point release out. Would end of November be OK for you, or do you need something sooner? Let us know!

@lbergelson
Copy link
Contributor Author

@lbergelson lbergelson commented Nov 7, 2016

Hi @fnothaft, thanks for the response. A December release is sooner than I had expected. I think it could work for us.

An end of November point release would be better though. We're going to be doing our own release hopefully in December and we'd like to not be relying on any self hosted sketchy snapshot releases then.

If it's a hassle though we can wait until December.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 8, 2016

I think we'd be targeting the last week of November, or possibly the week of Thanksgiving. CC @heuermh for comment.

@heuermh
Copy link
Member

@heuermh heuermh commented Nov 8, 2016

The current milestone date for 0.21.0 is Nov 15th. See #1088

@fnothaft fnothaft added this to the 0.21.0 milestone Nov 8, 2016
@lbergelson
Copy link
Contributor Author

@lbergelson lbergelson commented Nov 8, 2016

Ack, somehow I misread end of the month as end of next month. November 15th is great for us.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 8, 2016

No problem! I'm going to close this ticket as we're tracking the November 15th release target on #1088, but please ping us on either of the tickets if you have questions @lbergelson!

@fnothaft fnothaft closed this Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.