New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ANN field parsing unit tests #1273

Closed
jpdna opened this Issue Nov 16, 2016 · 5 comments

Comments

Projects
2 participants
@jpdna
Member

jpdna commented Nov 16, 2016

No description provided.

@jpdna jpdna added this to the 0.21.0 milestone Nov 16, 2016

@jpdna jpdna self-assigned this Nov 16, 2016

@heuermh heuermh modified the milestone: 0.21.0 Nov 16, 2016

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 16, 2016

Member

Sorry, looks like we're clobbering each other setting the milestone!

Member

heuermh commented Nov 16, 2016

Sorry, looks like we're clobbering each other setting the milestone!

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 16, 2016

Member

There is a lot of unit test coverage for the converter in
https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/test/scala/org/bdgenomics/adam/converters/TranscriptEffectConverterSuite.scala

Feel free to borrow from it as necessary.

Member

heuermh commented Nov 16, 2016

There is a lot of unit test coverage for the converter in
https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/test/scala/org/bdgenomics/adam/converters/TranscriptEffectConverterSuite.scala

Feel free to borrow from it as necessary.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Dec 29, 2016

Member

@jpdna Do you think any more tests need to be added to #1288 for this before it is merged?

Member

heuermh commented Dec 29, 2016

@jpdna Do you think any more tests need to be added to #1288 for this before it is merged?

@jpdna

This comment has been minimized.

Show comment
Hide comment
@jpdna

jpdna Dec 29, 2016

Member

No, seems fine to me.

Member

jpdna commented Dec 29, 2016

No, seems fine to me.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jan 5, 2017

Member

Fixed by #1288

Member

heuermh commented Jan 5, 2017

Fixed by #1288

@heuermh heuermh closed this Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment