Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceRegion on Genotype seems busted? #1286

Closed
fnothaft opened this issue Nov 20, 2016 · 0 comments
Closed

ReferenceRegion on Genotype seems busted? #1286

fnothaft opened this issue Nov 20, 2016 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Nov 20, 2016

Looking at the code:

def apply(genotype: Genotype): ReferenceRegion = {
  ReferenceRegion(genotype.getVariant)
}

After 525fda8, we don't set some of the Variant fields in Genotype. I'm curiously concerned as to how we haven't previously caught this?

@fnothaft fnothaft added the bug label Nov 20, 2016
@fnothaft fnothaft added this to the 0.21.0 milestone Nov 20, 2016
@fnothaft fnothaft self-assigned this Nov 20, 2016
fnothaft added a commit to fnothaft/adam that referenced this issue Nov 25, 2016
Resolves bigdatagenomics#1286. After commit 525fda8, we don't
set several of the fields in `Variant` when nested in a `Genotype`. Here, we add
code to `ReferenceRegion` to pull the fields that are not set in the nested
`Variant` from the core `Genotype` fields.
fnothaft added a commit to fnothaft/adam that referenced this issue Dec 8, 2016
Resolves bigdatagenomics#1286. After commit 525fda8, we don't
set several of the fields in `Variant` when nested in a `Genotype`. Here, we add
code to `ReferenceRegion` to pull the fields that are not set in the nested
`Variant` from the core `Genotype` fields.
@heuermh heuermh closed this in c49191b Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.