Allow list of commands to be injected into adam-cli AdamMain #132

Closed
heuermh opened this Issue Feb 22, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@heuermh
Member

heuermh commented Feb 22, 2014

The list of commands in AdamMain is private, so outside of the PluginExecutor mechanism, adding new commands requires modifying this list and rebuilding; this also introduces a circular dependency between the adam build and an external project.

Adding a new constructor to AdamMain with a reference to the list of commands as a parameter would allow the list to be provided by dependency injection (e.g. via Guice).

https://code.google.com/p/google-guice/

@karenfeng

This comment has been minimized.

Show comment
Hide comment
@karenfeng

karenfeng Jun 17, 2014

Contributor

Hey @heuermh, I was thinking about working on this issue. Are you already working on it, or can I go ahead?

Contributor

karenfeng commented Jun 17, 2014

Hey @heuermh, I was thinking about working on this issue. Are you already working on it, or can I go ahead?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jun 17, 2014

Member

@karenfeng I don't have time to work on it now, so if you want to pick it up, please do so. I'll try to help where I can.

Member

heuermh commented Jun 17, 2014

@karenfeng I don't have time to work on it now, so if you want to pick it up, please do so. I'll try to help where I can.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Mar 24, 2016

Member

Fixed by #762 and #854

Member

heuermh commented Mar 24, 2016

Fixed by #762 and #854

@heuermh heuermh closed this Mar 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment