New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adam-cli uses git-commit-id-plugin which breaks release? #1322

Closed
laserson opened this Issue Dec 21, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@laserson
Contributor

laserson commented Dec 21, 2016

I just downloaded a release of ADAM and tried to run mvn package -DskipTests which failed on the ADAM CLI module with

[ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.2.1:revision (default) on project adam-cli-spark2_2.11: .git directory is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1]

Is this expected?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Dec 22, 2016

Member

The problem is that release source tarballs don't have .git directories.

The git-commit-id-plugin populates template variables used in the --version text.

$ ./bin/adam-submit --version
Using ADAM_MAIN=org.bdgenomics.adam.cli.ADAMMain
Using SPARK_SUBMIT=/usr/local/bin/spark-submit

       e         888~-_          e             e    e
      d8b        888   \        d8b           d8b  d8b
     /Y88b       888    |      /Y88b         d888bdY88b
    /  Y88b      888    |     /  Y88b       / Y88Y Y888b
   /____Y88b     888   /     /____Y88b     /   YY   Y888b
  /      Y88b    888_-~     /      Y88b   /          Y888b

ADAM version: 0.20.1-SNAPSHOT
Commit: f14966cfc206b7e6efa76d255a1ef12159202317 Build: 2016-12-22
Built for: Scala 2.10.6 and Hadoop 2.7.3

I'm not sure of a workaround, let me think on it.

Member

heuermh commented Dec 22, 2016

The problem is that release source tarballs don't have .git directories.

The git-commit-id-plugin populates template variables used in the --version text.

$ ./bin/adam-submit --version
Using ADAM_MAIN=org.bdgenomics.adam.cli.ADAMMain
Using SPARK_SUBMIT=/usr/local/bin/spark-submit

       e         888~-_          e             e    e
      d8b        888   \        d8b           d8b  d8b
     /Y88b       888    |      /Y88b         d888bdY88b
    /  Y88b      888    |     /  Y88b       / Y88Y Y888b
   /____Y88b     888   /     /____Y88b     /   YY   Y888b
  /      Y88b    888_-~     /      Y88b   /          Y888b

ADAM version: 0.20.1-SNAPSHOT
Commit: f14966cfc206b7e6efa76d255a1ef12159202317 Build: 2016-12-22
Built for: Scala 2.10.6 and Hadoop 2.7.3

I'm not sure of a workaround, let me think on it.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Dec 22, 2016

Member

Looking at the usage docs—which are pretty solid!—there is an option to not fail if .git is missing:

                    <!-- @since 2.0.4 -->
                    <!-- true by default, controls whether the plugin will fail when no .git directory is found, when set to false the plugin will just skip execution -->                    
                    <failOnNoGitDirectory>true</failOnNoGitDirectory>
Member

fnothaft commented Dec 22, 2016

Looking at the usage docs—which are pretty solid!—there is an option to not fail if .git is missing:

                    <!-- @since 2.0.4 -->
                    <!-- true by default, controls whether the plugin will fail when no .git directory is found, when set to false the plugin will just skip execution -->                    
                    <failOnNoGitDirectory>true</failOnNoGitDirectory>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment