New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close called multiple times on VCF header stream #1337

Closed
fnothaft opened this Issue Jan 3, 2017 · 0 comments

Comments

Projects
1 participant
@fnothaft
Member

fnothaft commented Jan 3, 2017

I think this doesn't show up in our tests because the stream returned by Hadoop's LocalFileSystem implementation allows close to be called multiple times, but the stream returned by HDFS does not allow close to be called multiple times.

@fnothaft fnothaft added the bug label Jan 3, 2017

@fnothaft fnothaft added this to the 0.21.0 milestone Jan 3, 2017

@fnothaft fnothaft self-assigned this Jan 3, 2017

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 3, 2017

[ADAM-1337] Remove os.{flush,close} calls after writing VCF header.
Resolves #1337. The VCF writer calls close on the underlying stream.

@heuermh heuermh closed this in #1338 Jan 4, 2017

heuermh added a commit that referenced this issue Jan 4, 2017

[ADAM-1337] Remove os.{flush,close} calls after writing VCF header.
Resolves #1337. The VCF writer calls close on the underlying stream.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 5, 2017

[ADAM-1337] Remove os.{flush,close} calls after writing VCF header.
Resolves #1337. The VCF writer calls close on the underlying stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment