New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase visibility for SupportedHeaderLines.allHeaderLines #1372

Closed
heuermh opened this Issue Jan 24, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@heuermh
Member

heuermh commented Jan 24, 2017

[INFO] Compiling 6 Scala sources to target/scala-2.10.6/classes...
[ERROR] .../Freebayes.scala:77: object SupportedHeaderLines in package converters
cannot be accessed in package org.bdgenomics.adam.converters
[ERROR] implicit val uFormatter = new VCFOutFormatter(SupportedHeaderLines.allHeaderLines)

In this specific use case I'd like to add Freebayes-specific headers to the ones we already support, something like

val freebayesHeaderLines = Seq( ... )
val headerLines = SupportedHeaderLines.addHeaderLines ++ freebayesHeaderLines
implicit val uFormatter = new VCFOutFormatter(headerLines)
@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 24, 2017

Member

+1, although perhaps we should do a name change as well? SupportedHeaderLines makes it sound like all other header lines will be lost.

Member

fnothaft commented Jan 24, 2017

+1, although perhaps we should do a name change as well? SupportedHeaderLines makes it sound like all other header lines will be lost.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jan 24, 2017

Member

Ah that's right, we combine those in the input VCF with our supported header lines, so I don't actually need to define freebayes specific header lines. How about rename to VCFHeaderLines?

Member

heuermh commented Jan 24, 2017

Ah that's right, we combine those in the input VCF with our supported header lines, so I don't actually need to define freebayes specific header lines. How about rename to VCFHeaderLines?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 24, 2017

Member

That's a little too close to htsjdk.variant.vcf.VCFHeaderLine for me.

Member

fnothaft commented Jan 24, 2017

That's a little too close to htsjdk.variant.vcf.VCFHeaderLine for me.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Jan 24, 2017

Member

ok, propose away :)

Member

heuermh commented Jan 24, 2017

ok, propose away :)

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jan 24, 2017

Member

Perhaps DefaultHeaderLines, since they're what we add by default.

Member

fnothaft commented Jan 24, 2017

Perhaps DefaultHeaderLines, since they're what we add by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment