New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRDD.toCoverage throws NullPointerException when there is no coverage information #1471

Closed
devin-petersohn opened this Issue Apr 4, 2017 · 1 comment

Comments

Projects
3 participants
@devin-petersohn
Member

devin-petersohn commented Apr 4, 2017

This is more of a discussion on how to handle this case.

Do we want to leave it, or should we add a require()?

The exception isn't thrown until the CoverageRDD is materialized, and NullPointerExceptions are notoriously difficult to debug at times.

I think it would be nicer to have in ADAM, but I am also happy to handle this exception downstream if that is the consensus.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 4, 2017

Member

I would +1 adding a require. IMO, users shouldn't see a NPE.

Member

fnothaft commented Apr 4, 2017

I would +1 adding a require. IMO, users shouldn't see a NPE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment