Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Phred score gets bumped by 33 twice in BQSR #1488

Closed
fnothaft opened this issue Apr 13, 2017 · 0 comments
Closed

Min Phred score gets bumped by 33 twice in BQSR #1488

fnothaft opened this issue Apr 13, 2017 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Apr 13, 2017

Paranoia sweeps the nation as an implicit conversion from Char to Int allows the minAcceptablePhred score to be incremented by 33 twice in the AlignmentRecordRDD->BaseQualityScoreRecalibration codepath. Troubled developers ask each other: could my Chars be the next target of implicit conversion? Find out more tonight.

For those watching at home, the first bump is here and the second bump is here.

@fnothaft fnothaft added the bug label Apr 13, 2017
@fnothaft fnothaft added this to the 0.23.0 milestone Apr 13, 2017
@fnothaft fnothaft self-assigned this Apr 13, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Apr 14, 2017
heuermh added a commit that referenced this issue Apr 14, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.