Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceRegion overlaps and covers returns false if overlap is 1 #1492

Closed
devin-petersohn opened this issue Apr 16, 2017 · 3 comments
Closed

ReferenceRegion overlaps and covers returns false if overlap is 1 #1492

devin-petersohn opened this issue Apr 16, 2017 · 3 comments
Labels
Milestone

Comments

@devin-petersohn
Copy link
Member

@devin-petersohn devin-petersohn commented Apr 16, 2017

ReferenceRegion("chr0", 10, 100).overlaps(region("chr0", 100, 110)))
ReferenceRegion("chr0", 10, 100).covers(region("chr0", 100, 110)))

Should these be returning false?

Referencing #1473, #1474.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Apr 16, 2017

They should return false. Our coordinate system is 0-based half-open --> i.e., in an interval, start is inclusive, end is exclusive.

@devin-petersohn
Copy link
Member Author

@devin-petersohn devin-petersohn commented Apr 16, 2017

I knew this on Friday, sorry for the silly question.

Closing as question answered.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Apr 16, 2017

No sweat!

@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.