New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split apart #1324 #1507

Closed
devin-petersohn opened this Issue Apr 28, 2017 · 2 comments

Comments

Projects
3 participants
@devin-petersohn
Member

devin-petersohn commented Apr 28, 2017

Split apart #1324 into separate PR for sorted PR and joins rework PR.

Maintaining sorted knowledge can help in optimizations for downstream applications, but the join part of #1324 is monstrous.

I believe that separating the PR into separate sorted/join PRs can expedite the process for getting the sort and partition map knowledge into ADAM. Thoughts?

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Apr 28, 2017

Member

I mean, my general sense was that #1324 was about a week away from being ready to merge, just depending on you feeling done with it and me and @heuermh doing another review pass? Since @akmorrow13 is pretty booked up for the next week with end-of-semester stuff, I'd rather not split the PR, unless you feel like it would make the work easier for you.

Member

fnothaft commented Apr 28, 2017

I mean, my general sense was that #1324 was about a week away from being ready to merge, just depending on you feeling done with it and me and @heuermh doing another review pass? Since @akmorrow13 is pretty booked up for the next week with end-of-semester stuff, I'd rather not split the PR, unless you feel like it would make the work easier for you.

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn May 1, 2017

Member

Closing: agreement was reached.

Member

devin-petersohn commented May 1, 2017

Closing: agreement was reached.

@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment