New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor filterByOverlappingRegions not to require a List #1549

Closed
heuermh opened this Issue May 26, 2017 · 2 comments

Comments

Projects
3 participants
@heuermh
Member

heuermh commented May 26, 2017

Could filterByOverlappingRegions(List[ReferenceRegion]) accept Traversable or Iterable instead of List?

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn May 26, 2017

Member

+1, I don't see a reason to require a List here.

Member

devin-petersohn commented May 26, 2017

+1, I don't see a reason to require a List here.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft May 26, 2017

Member

+1, I'd been thinking the same.

Member

fnothaft commented May 26, 2017

+1, I'd been thinking the same.

@heuermh heuermh changed the title from Does filterByOverlappingRegions require a List? to Refactor filterByOverlappingRegions not to require a List May 27, 2017

fnothaft added a commit to fnothaft/adam that referenced this issue May 27, 2017

@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment