Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interleaved FASTQ recognizes only /1 suffix pattern #1589

Closed
heuermh opened this issue Jul 6, 2017 · 1 comment
Closed

Interleaved FASTQ recognizes only /1 suffix pattern #1589

heuermh opened this issue Jul 6, 2017 · 1 comment
Milestone

Comments

@heuermh
Copy link
Member

@heuermh heuermh commented Jul 6, 2017

FastqRecordConverter supports read suffixes with a few different patterns, [space]1, +1, _1, and /1. I've seen [space]1 and /1 in the wild.

InterleavedFastqInputFormat only recognizes /1, resulting in empty FragmentRDDs if the interleaved FASTQ file uses one of the other patterns.

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 11, 2017
Resolves bigdatagenomics#1585, bigdatagenomics#1589. Adds regex to cover new metadata that Illumina added into
FASTQ name line. Also, adds a regex to the InterleavedFastqInputFormat that
checks for a wider range of supported first-of-read ending suffices.
heuermh added a commit that referenced this issue Jul 11, 2017
Resolves #1585, #1589. Adds regex to cover new metadata that Illumina added into
FASTQ name line. Also, adds a regex to the InterleavedFastqInputFormat that
checks for a wider range of supported first-of-read ending suffices.
@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 11, 2017

Resolved by 7a11d9e.

@fnothaft fnothaft closed this Jul 11, 2017
@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.