Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala copy method not supported in abstract classes such as AlignmentRecordRDD #1599

Closed
heuermh opened this issue Jul 11, 2017 · 4 comments
Closed
Milestone

Comments

@heuermh
Copy link
Member

@heuermh heuermh commented Jul 11, 2017

@devin-petersohn
Copy link
Member

@devin-petersohn devin-petersohn commented Jul 11, 2017

Are you wanting to add def copy(...) to RDDBoundAlignmentRecordRDD and DatasetBoundAlignmentRecordRDD?

@heuermh
Copy link
Member Author

@heuermh heuermh commented Jul 11, 2017

No, it isn't present on AlignmentRecordRDD, which is abstract

@devin-petersohn
Copy link
Member

@devin-petersohn devin-petersohn commented Jul 12, 2017

Are you wanting an abstract definition in AlignmentRecordRDD, and then implementations in the above mentioned classes?

If you don't want changes in ADAM, you could just use the Companion object:
AlignmentRecordRDD(rdd, sequences, recordGroups)

@heuermh
Copy link
Member Author

@heuermh heuermh commented Jul 12, 2017

That was my fix in bigdatagenomics/cannoli#56. The copy method is some Scala magick, I'm not sure if we want to add explict ones everywhere.

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 12, 2017
Resolves bigdatagenomics#1599. Adds functions that replaces or appends to the
sequence dictionary/record groups/header lines/sample metadata that is attached
to a GenomicRDD. This is necessary as a59b8ed
eliminated the `copy` methods that were attached to all implementations of
`GenomicRDD` by making the exposed implementations abstract classes instead of
case classes.
@fnothaft fnothaft added this to the 0.23.0 milestone Jul 12, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 12, 2017
Resolves bigdatagenomics#1599. Adds functions that replaces or appends to the
sequence dictionary/record groups/header lines/sample metadata that is attached
to a GenomicRDD. This is necessary as a59b8ed
eliminated the `copy` methods that were attached to all implementations of
`GenomicRDD` by making the exposed implementations abstract classes instead of
case classes.
devin-petersohn added a commit that referenced this issue Jul 12, 2017
Resolves #1599. Adds functions that replaces or appends to the
sequence dictionary/record groups/header lines/sample metadata that is attached
to a GenomicRDD. This is necessary as a59b8ed
eliminated the `copy` methods that were attached to all implementations of
`GenomicRDD` by making the exposed implementations abstract classes instead of
case classes.
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.