New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VariantRDD doesn't save partition map #1601

Closed
heuermh opened this Issue Jul 12, 2017 · 1 comment

Comments

Projects
2 participants
@heuermh
Member

heuermh commented Jul 12, 2017

@devin-petersohn I noticed that VariantRDD doesn't call AvroGenomicRDD.savePartitionMap in saveMetadata.

https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/scala/org/bdgenomics/adam/rdd/variant/VariantRDD.scala#L182

Was this omission intentional?

@devin-petersohn

This comment has been minimized.

Show comment
Hide comment
@devin-petersohn

devin-petersohn Jul 12, 2017

Member

No this was not intended, but I believe @fnothaft has a better way to handle the optPartitionMap in #1590.

Member

devin-petersohn commented Jul 12, 2017

No this was not intended, but I believe @fnothaft has a better way to handle the optPartitionMap in #1590.

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 12, 2017

Rename AvroReadGroupGenomicRDD to AvroRecordGroupGenomicRDD and move …
…VCF headers

to GenotypeRDD. Cleans up metadata save in VariantRDD. Resolves bigdatagenomics#1601.

@heuermh heuermh modified the milestone: 0.23.0 Jul 22, 2017

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment