New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Distribution Does not include jar files #1607

Closed
pbashyal-nmdp opened this Issue Jul 13, 2017 · 1 comment

Comments

Projects
2 participants
@pbashyal-nmdp
Contributor

pbashyal-nmdp commented Jul 13, 2017

The sanpshot distribution in https://oss.sonatype.org/content/repositories/snapshots/org/bdgenomics/adam/adam-distribution-spark2_2.11/0.23.0-SNAPSHOT/ is not complete. The jar files are not in the distribution.

Eg. adam-distribution_2.11-0.23.0-20170711.025002-241-bin.tar.bz2 expands to:

[adam-distribution-spark2_2.11-0.23.0-SNAPSHOT]$ ls -la
total 196
drwxrwxr-x 5 hadoop hadoop   4096 Jul 13 16:30 .
drwxr-xr-x 6 hadoop hadoop   4096 Jul 13 16:41 ..
drwxr-xr-x 2 hadoop hadoop   4096 Jul 11 02:35 bin
-rw-r--r-- 1 hadoop hadoop 123491 Jun 24 11:20 CHANGES.md
-rw-r--r-- 1 hadoop hadoop   5151 Jun 24 11:20 CONTRIBUTING.md
drwxr-xr-x 3 hadoop hadoop   4096 Jul 11 02:52 javadocs
-rw-r--r-- 1 hadoop hadoop  16714 Jun 24 11:20 LICENSE.txt
-rw-r--r-- 1 hadoop hadoop  24094 Jun 24 11:20 README.md
drwxr-xr-x 5 hadoop hadoop   4096 Jul 11 02:46 scaladocs

@fnothaft fnothaft added this to the 0.23.0 milestone Jul 21, 2017

@fnothaft fnothaft self-assigned this Jul 21, 2017

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 21, 2017

Member

Thanks for flagging this @pbashyal-nmdp! I see exactly what's going on here; we changed the assembly JAR name and forgot to change it in the distribution package.

Member

fnothaft commented Jul 21, 2017

Thanks for flagging this @pbashyal-nmdp! I see exactly what's going on here; we changed the assembly JAR name and forgot to change it in the distribution package.

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 22, 2017

[ADAM-1607] Update distribution assembly task to attach assembly über…
…jar.

Resolves bigdatagenomics#1607. 3ea4f18 renamed the überjar
generated by the adam-assembly package from `adam_<version>.jar` to
`adam-assembly_<version>.jar`, but did not update the distribution
assembly task. This commit updates that task, and adds code to `jenkins-test`
to ensure that the assembly jar is packaged in the distribution.

fnothaft added a commit to fnothaft/adam that referenced this issue Jul 22, 2017

[ADAM-1607] Update distribution assembly task to attach assembly über…
…jar.

Resolves bigdatagenomics#1607. 3ea4f18 renamed the überjar
generated by the adam-assembly package from `adam_<version>.jar` to
`adam-assembly_<version>.jar`, but did not update the distribution
assembly task. This commit updates that task, and adds code to `jenkins-test`
to ensure that the assembly jar is packaged in the distribution.

heuermh added a commit that referenced this issue Jul 22, 2017

[ADAM-1607] Update distribution assembly task to attach assembly über…
…jar.

Resolves #1607. 3ea4f18 renamed the überjar
generated by the adam-assembly package from `adam_<version>.jar` to
`adam-assembly_<version>.jar`, but did not update the distribution
assembly task. This commit updates that task, and adds code to `jenkins-test`
to ensure that the assembly jar is packaged in the distribution.

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment