Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose VariantContextRDD in R/Python #1614

Closed
fnothaft opened this issue Jul 21, 2017 · 0 comments
Closed

Expose VariantContextRDD in R/Python #1614

fnothaft opened this issue Jul 21, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 21, 2017

Realized we are missing this while going through #1613.

@fnothaft fnothaft added this to the 0.23.0 milestone Jul 21, 2017
@fnothaft fnothaft self-assigned this Jul 21, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 24, 2017
Resolves bigdatagenomics#1614. Restructures both R and Python APIs to add `GenomicDataset`
class, which inherits from `GenomicRDD`, as in adam-core. Moves all implementing
classes onto `GenomicDataset`, and adds `VariantContextRDD` which is the lone
class that extends `GenomicRDD`. Deletes `saveAsVcf` from `GenotypeRDD` and
`VariantRDD`, and moves this functionality into `toVariantContextRDD` functions
and `VariantContextRDD.saveAsVcf`. Additionally, adds `sort` and
`sortLexicographically` to the R API, and fixes `sortLexicographically` in
the Python API (it was calling `sort` previously).
fnothaft added a commit to fnothaft/adam that referenced this issue Jul 24, 2017
Resolves bigdatagenomics#1614. Restructures both R and Python APIs to add `GenomicDataset`
class, which inherits from `GenomicRDD`, as in adam-core. Moves all implementing
classes onto `GenomicDataset`, and adds `VariantContextRDD` which is the lone
class that extends `GenomicRDD`. Deletes `saveAsVcf` from `GenotypeRDD` and
`VariantRDD`, and moves this functionality into `toVariantContextRDD` functions
and `VariantContextRDD.saveAsVcf`. Additionally, adds `sort` and
`sortLexicographically` to the R API, and fixes `sortLexicographically` in
the Python API (it was calling `sort` previously).
heuermh added a commit that referenced this issue Jul 25, 2017
Resolves #1614. Restructures both R and Python APIs to add `GenomicDataset`
class, which inherits from `GenomicRDD`, as in adam-core. Moves all implementing
classes onto `GenomicDataset`, and adds `VariantContextRDD` which is the lone
class that extends `GenomicRDD`. Deletes `saveAsVcf` from `GenotypeRDD` and
`VariantRDD`, and moves this functionality into `toVariantContextRDD` functions
and `VariantContextRDD.saveAsVcf`. Additionally, adds `sort` and
`sortLexicographically` to the R API, and fixes `sortLexicographically` in
the Python API (it was calling `sort` previously).
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.