Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect grep for assembly jars in bin/pyadam #1647

Closed
akmorrow13 opened this issue Jul 30, 2017 · 1 comment
Closed

incorrect grep for assembly jars in bin/pyadam #1647

akmorrow13 opened this issue Jul 30, 2017 · 1 comment
Labels
bug
Milestone

Comments

@akmorrow13
Copy link
Contributor

@akmorrow13 akmorrow13 commented Jul 30, 2017

the pyadam script has the incorrect grep for the assembly jars at https://github.com/bigdatagenomics/adam/blob/master/bin/pyadam#L33

Should
grep "^adam_[0-9A-Za-z\.-]*\.jar$"
be
^adam-assembly_[0-9A-Za-z\.-]*\.jar$" ?

Unless I am missing the jar it is supposed to be accessing.

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Jul 30, 2017

Thanks for catching this @akmorrow13! It should be "^adam[0-9A-Za-z\.\_\-]*\.jar$", as it is in adam-submit

heuermh added a commit that referenced this issue Jul 30, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.