New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect grep for assembly jars in bin/pyadam #1647

Closed
akmorrow13 opened this Issue Jul 30, 2017 · 1 comment

Comments

Projects
2 participants
@akmorrow13
Contributor

akmorrow13 commented Jul 30, 2017

the pyadam script has the incorrect grep for the assembly jars at https://github.com/bigdatagenomics/adam/blob/master/bin/pyadam#L33

Should
grep "^adam_[0-9A-Za-z\.-]*\.jar$"
be
^adam-assembly_[0-9A-Za-z\.-]*\.jar$" ?

Unless I am missing the jar it is supposed to be accessing.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Jul 30, 2017

Member

Thanks for catching this @akmorrow13! It should be "^adam[0-9A-Za-z\.\_\-]*\.jar$", as it is in adam-submit

Member

fnothaft commented Jul 30, 2017

Thanks for catching this @akmorrow13! It should be "^adam[0-9A-Za-z\.\_\-]*\.jar$", as it is in adam-submit

@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment