Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance benchmarks similar to Samtools CRAM benchmarking page #1661

Closed
heuermh opened this issue Aug 8, 2017 · 1 comment
Closed

Add performance benchmarks similar to Samtools CRAM benchmarking page #1661

heuermh opened this issue Aug 8, 2017 · 1 comment
Milestone

Comments

@heuermh
Copy link
Member

@heuermh heuermh commented Aug 8, 2017

Add performance benchmarks similar to http://www.htslib.org/benchmarks/CRAM.html on the same data.

Although I'm not sure these particular benchmarks actually do anything. Can anyone translate?

"Conversion from BAM to is achieved via htslib test_view -b or -C. Decoding times are computed using test_view -B (benchmarking mode) with performs input, uncompression and decoding only. Encoding time includes decoding of the input BAM, so subtract the BAM decoding time to get encode-only, although the difference is only minor."

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Aug 8, 2017

I think the size benchmarks are reasonable. The decoding time benchmarks are a bit hard to interpret, and are probably more interpretable as application level benchmarks like in #1634.

@heuermh heuermh modified the milestone: 0.23.0 Sep 1, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Oct 21, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Oct 21, 2017
fnothaft added a commit to fnothaft/adam that referenced this issue Nov 6, 2017
@heuermh heuermh closed this in #1772 Nov 7, 2017
heuermh added a commit that referenced this issue Nov 7, 2017
@heuermh heuermh added this to Completed in Release 0.23.0 Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.