New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Shuffle Join Implementation - Left Outer + Group By Left #1745

Closed
devin-petersohn opened this Issue Sep 26, 2017 · 2 comments

Comments

Projects
3 participants
@devin-petersohn
Member

devin-petersohn commented Sep 26, 2017

This is needed to correctly implement a subtract primitive. Without a group by the subtraction returns incorrect intervals.

@fnothaft, @heuermh thoughts on return type? It can be:
GenericGenomicRDD[(T, Iterable[Option[X]]
or
GenericGenomicRDD[(T, Iterable[X]] (flattened, so some empty Iterables).

I have no strong preference.

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Sep 26, 2017

Member

I vote for (T, Iterable[X]), an option is already iterable.

Member

heuermh commented Sep 26, 2017

I vote for (T, Iterable[X]), an option is already iterable.

@fnothaft

This comment has been minimized.

Show comment
Hide comment
@fnothaft

fnothaft Sep 26, 2017

Member

SGTM, definitely (T, Iterable[X]).

Member

fnothaft commented Sep 26, 2017

SGTM, definitely (T, Iterable[X]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment