New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit `<compile>` scopes from submodule POMs #1786

Closed
fnothaft opened this Issue Oct 29, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@fnothaft
Member

fnothaft commented Oct 29, 2017

Hi @heuermh wanted your thoughts on this. I know you added these a few months back in 9505d47 and that we had discussed this at the time, but I can't remember what the exact rationale was, and the attached issue doesn't seem to discuss the rationale (its long so I skimmed it and may have missed the discussion). This is really a question of convenience; I was debugging something today so changed a dependency from compile to provided scope. However, since I didn't update the submodule POMs, it was still packaged at compile scope. This was a bit of a hassle since the specific debugging loop was pretty long (it involved deploying the assembly JAR over a slow internet connection). That said, I remember you had a reason for adding the explicit scopes, so I wanted to circle back. Can you jog my memory? No need to change this now, just wanted to create a ticket for discussion.

@heuermh

This comment has been minimized.

Member

heuermh commented Oct 30, 2017

The motivation was simply to be informational, since scope is compile by default if not specified and some of the scopes were inherited as provided from parent. It has a side effect of making it more painful to change the scope on a dependency, as you found out.

@fnothaft

This comment has been minimized.

Member

fnothaft commented Oct 30, 2017

Yeah, I'm not sure which way is best. On one hand, I like having the scope explicitly visible. On the other hand, making changes is a bit of a PITA. Anyone else have strong feelings?

As an aside, I think we've got a few dependencies where we forgot to set the scope in the submodule POMs.

@fnothaft fnothaft added the wontfix label Mar 7, 2018

@fnothaft

This comment has been minimized.

Member

fnothaft commented Mar 7, 2018

I don't feel strong in favor of removing the scopes, so closing for now.

@fnothaft fnothaft closed this Mar 7, 2018

@heuermh heuermh added this to the 0.24.0 milestone Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment