New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only python 2? #1871

Closed
zfrenchee opened this Issue Jan 12, 2018 · 2 comments

Comments

2 participants
@zfrenchee

zfrenchee commented Jan 12, 2018

Hello ADAM developers,
I just found this project and it looks like exactly what I'm looking for. I made the switch some time ago from python2 to python3 as my default. It seems like ADAM might be only python2 compatible. Is that right?

/Documents/genomics_project(master) » pip install bdgenomics.adam
Collecting bdgenomics.adam
  Downloading bdgenomics.adam-0.23.0.tar.gz (48.3MB)
    100% |████████████████████████████████| 48.4MB 27kB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/0w/fzyy4qz93l56_bh1jyn3vgp00000gn/T/pip-build-niuwhkvj/bdgenomics.adam/setup.py", line 25, in <module>
        from version import version as adam_version
      File "/private/var/folders/0w/fzyy4qz93l56_bh1jyn3vgp00000gn/T/pip-build-niuwhkvj/bdgenomics.adam/version.py", line 22
        print version
                    ^
    SyntaxError: Missing parentheses in call to 'print'. Did you mean print(int version)?

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/0w/fzyy4qz93l56_bh1jyn3vgp00000gn/T/pip-build-niuwhkvj/bdgenomics.adam/
@fnothaft

This comment has been minimized.

Member

fnothaft commented Jan 12, 2018

Hi! I don't actually think we've got any functionality that needs Python 2, rather we've possibly been inattentive to a few things that need to be _futureize_d. I'd be glad to give Python 3 compat a check!

@zfrenchee

This comment has been minimized.

zfrenchee commented Jan 13, 2018

I switched to python2 and this successfully installed, so I can confirm this is a python2/python3 issue.

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 20, 2018

fnothaft added a commit to fnothaft/adam that referenced this issue Jan 21, 2018

[ADAM-1871] Fix print call that broke python 3 support.
Resolves bigdatagenomics#1871. Also adds a loop to the `jenkins-test` script to test both
Python 2.7 and 3.6.

@fnothaft fnothaft added this to the 0.24.0 milestone Jan 21, 2018

@fnothaft fnothaft added the bug label Jan 21, 2018

heuermh added a commit that referenced this issue Jan 22, 2018

[ADAM-1871] Fix print call that broke python 3 support.
Resolves #1871. Also adds a loop to the `jenkins-test` script to test both
Python 2.7 and 3.6.

@heuermh heuermh added this to Completed in Release 0.24.0 Feb 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment