Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAMContext.getFsAndFilesWithFilter should throw exception if paths null or empty #1932

Closed
heuermh opened this Issue Mar 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@heuermh
Copy link
Member

commented Mar 2, 2018

Shouldn't this code block be throwing an exception?

    val paths = if (fs.isDirectory(path)) {
      val paths = fs.listStatus(path)

      if (paths == null || paths.isEmpty) {
        s"Couldn't find any files matching ${path.toUri}"
      }
      fs.listStatus(path, filter)
}

https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ADAMContext.scala#L1371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.