Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip phred scores below Int.MaxValue #1934

Closed
fnothaft opened this issue Mar 2, 2018 · 0 comments
Closed

Clip phred scores below Int.MaxValue #1934

fnothaft opened this issue Mar 2, 2018 · 0 comments
Milestone

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 2, 2018

While #1569 improved the resolution that our phred score converter covered, it still clips around Phred 3233. We should saturate there, instead of at Int.MaxValue.

@fnothaft fnothaft added this to the 0.24.0 milestone Mar 2, 2018
fnothaft pushed a commit to fnothaft/adam that referenced this issue Mar 3, 2018
Resolves bigdatagenomics#1934. When phred values underflow log space double precision floating
point numbers, clip them to the lowest phred score representable as a log valued
double (3233), instead of Int.MaxValue.
@heuermh heuermh closed this in #1936 Mar 4, 2018
heuermh added a commit that referenced this issue Mar 4, 2018
Resolves #1934. When phred values underflow log space double precision floating
point numbers, clip them to the lowest phred score representable as a log valued
double (3233), instead of Int.MaxValue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant