New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip phred scores below Int.MaxValue #1934

Closed
fnothaft opened this Issue Mar 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@fnothaft
Member

fnothaft commented Mar 2, 2018

While #1569 improved the resolution that our phred score converter covered, it still clips around Phred 3233. We should saturate there, instead of at Int.MaxValue.

@fnothaft fnothaft added this to the 0.24.0 milestone Mar 2, 2018

fnothaft added a commit to fnothaft/adam that referenced this issue Mar 3, 2018

[ADAM-1934] Clip phred values to 3233, instead of Int.MaxValue.
Resolves bigdatagenomics#1934. When phred values underflow log space double precision floating
point numbers, clip them to the lowest phred score representable as a log valued
double (3233), instead of Int.MaxValue.

@heuermh heuermh closed this in #1936 Mar 4, 2018

heuermh added a commit that referenced this issue Mar 4, 2018

[ADAM-1934] Clip phred values to 3233, instead of Int.MaxValue.
Resolves #1934. When phred values underflow log space double precision floating
point numbers, clip them to the lowest phred score representable as a log valued
double (3233), instead of Int.MaxValue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment