Skip to content

/ adam

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't initialize non-ref values to Int.MinValue #1957

Closed
fnothaft opened this issue Mar 20, 2018 · 0 comments
Closed

Don't initialize non-ref values to Int.MinValue #1957

fnothaft opened this issue Mar 20, 2018 · 0 comments
Assignees
@fnothaft
Labels
bug
Projects
Release 0.24.0
Milestone
0.24.0

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 20, 2018

https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/scala/org/bdgenomics/adam/converters/VariantContextConverter.scala#L1077
@fnothaft fnothaft added the bug label Mar 20, 2018
@fnothaft fnothaft added this to the 0.24.0 milestone Mar 20, 2018
@fnothaft fnothaft self-assigned this Mar 20, 2018
fnothaft pushed a commit to fnothaft/adam that referenced this issue Mar 22, 2018
Frank Austin Nothaft
[ADAM-1957] Don't initialize missing likelihoods to MinValue.
8a0aba2 
Resolves bigdatagenomics#1957. Introduces a PhredUtils maximum value constant.
@fnothaft fnothaft mentioned this issue Mar 22, 2018
Merged
heuermh added a commit that referenced this issue Mar 23, 2018
Frank Austin Nothaft @heuermh
[ADAM-1957] Don't initialize missing likelihoods to MinValue.
a09cfde 
Resolves #1957. Introduces a PhredUtils maximum value constant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnothaft fnothaft

Labels
bug
Projects
Release 0.24.0
Awaiting triage
Milestone
0.24.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@fnothaft