Skip to content

/ adam

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phred values from 156–254 do not round trip properly between log space #1964

Closed
fnothaft opened this issue Mar 23, 2018 · 0 comments
Closed

Phred values from 156–254 do not round trip properly between log space #1964

fnothaft opened this issue Mar 23, 2018 · 0 comments
Assignees
@fnothaft
Labels
bug
Milestone
0.24.0

Comments

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 23, 2018

No description provided.

@fnothaft fnothaft added the bug label Mar 23, 2018
@fnothaft fnothaft added this to the 0.24.0 milestone Mar 23, 2018
@fnothaft fnothaft self-assigned this Mar 23, 2018
fnothaft pushed a commit to fnothaft/adam that referenced this issue Mar 23, 2018
Frank Austin Nothaft
[ADAM-1964] Lower point where phred conversions are done using log code.
394f9f6 
Resolves bigdatagenomics#1964. There was an underflow somewhere causing round trip from
log space values to Phred to mismatch for values between 164 and 254.
This change lowers the point where we switch from using the precomputed
table to where we use the log math. Also, we add a unit test checking
round trip values using PhredUtils.
@fnothaft fnothaft mentioned this issue Mar 23, 2018
Merged
fnothaft pushed a commit to fnothaft/adam that referenced this issue Mar 23, 2018
Frank Austin Nothaft
[ADAM-1964] Lower point where phred conversions are done using log code.
03054f2 
Resolves bigdatagenomics#1964. There was an underflow somewhere causing round trip from
log space values to Phred to mismatch for values between 164 and 254.
This change lowers the point where we switch from using the precomputed
table to where we use the log math. Also, we add a unit test checking
round trip values using PhredUtils.
fnothaft pushed a commit to fnothaft/adam that referenced this issue Mar 23, 2018
Frank Austin Nothaft
[ADAM-1964] Lower point where phred conversions are done using log code.
eea8864 
Resolves bigdatagenomics#1964. There was an underflow somewhere causing round trip from
log space values to Phred to mismatch for values between 164 and 254.
This change lowers the point where we switch from using the precomputed
table to where we use the log math. Also, we add a unit test checking
round trip values using PhredUtils.
heuermh added a commit that referenced this issue Mar 23, 2018
Frank Austin Nothaft @heuermh
[ADAM-1964] Lower point where phred conversions are done using log code.
c15b129 
Resolves #1964. There was an underflow somewhere causing round trip from
log space values to Phred to mismatch for values between 164 and 254.
This change lowers the point where we switch from using the precomputed
table to where we use the log math. Also, we add a unit test checking
round trip values using PhredUtils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnothaft fnothaft

Labels
bug
Projects
None yet
Milestone
0.24.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@fnothaft