Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand illumina metadata regex to include "N" character #2079

Closed
pauldwolfe opened this issue Nov 6, 2018 · 1 comment
Closed

Expand illumina metadata regex to include "N" character #2079

pauldwolfe opened this issue Nov 6, 2018 · 1 comment
Assignees
Milestone

Comments

@pauldwolfe
Copy link
Contributor

@pauldwolfe pauldwolfe commented Nov 6, 2018

ADAM-1697 we added possible characters (non-numeric) in order to match all illumina generate metadata suffixes in fastq files. Turns out we missed "N" which is also possibly used.

@pauldwolfe pauldwolfe self-assigned this Nov 6, 2018
@pauldwolfe
Copy link
Contributor Author

@pauldwolfe pauldwolfe commented Nov 7, 2018

Closing in favor of PR

@pauldwolfe pauldwolfe closed this Nov 7, 2018
@heuermh heuermh added this to the 0.25.0 milestone Nov 7, 2018
@heuermh heuermh reopened this Nov 7, 2018
@heuermh heuermh changed the title Expand illumina metadata regex once again Expand illumina metadata regex to include "N" character Nov 7, 2018
@heuermh heuermh closed this in #2081 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants