New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move_to_scala_2.11 and maven-javadoc-plugin #863

Closed
fnothaft opened this Issue Oct 10, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@fnothaft
Member

fnothaft commented Oct 10, 2015

The script we use to build Scala 2.11 blindly overwrites the maven-javadoc-plugin version to a version that doesn't exist.

As an aside, @AmplabJenkins should be catching this. Why isn't that failing our builds? Find out later on the news at 11.

@fnothaft fnothaft added the bug label Oct 10, 2015

@fnothaft fnothaft self-assigned this Oct 10, 2015

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 21, 2015

Member

I use more explicit sed replacements and ${scala.artifact.suffix} everywhere here
https://github.com/heuermh/adam-plugins/blob/master/scripts/move_to_scala_2.11.sh

Member

heuermh commented Oct 21, 2015

I use more explicit sed replacements and ${scala.artifact.suffix} everywhere here
https://github.com/heuermh/adam-plugins/blob/master/scripts/move_to_scala_2.11.sh

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Oct 23, 2015

Member

I was wondering if the javadocs for the Scala 2.11 release of version 0.18.0 are broken, and it appears they are fine

http://search.maven.org/remotecontent?filepath=org/bdgenomics/adam/adam-core_2.11/0.18.0/adam-core_2.11-0.18.0-javadoc.jar

./scripts/move_to_scala_2.11.sh is called by the release script ./scripts/release/release.sh, apparently this isn't a problem for release either?

Member

heuermh commented Oct 23, 2015

I was wondering if the javadocs for the Scala 2.11 release of version 0.18.0 are broken, and it appears they are fine

http://search.maven.org/remotecontent?filepath=org/bdgenomics/adam/adam-core_2.11/0.18.0/adam-core_2.11-0.18.0-javadoc.jar

./scripts/move_to_scala_2.11.sh is called by the release script ./scripts/release/release.sh, apparently this isn't a problem for release either?

@heuermh

This comment has been minimized.

Show comment
Hide comment
@heuermh

heuermh Nov 11, 2015

Member

Wasn't sure before but can confirm that this breaks the release.sh script. Had to manually fix this during the 0.18.2 release.

Member

heuermh commented Nov 11, 2015

Wasn't sure before but can confirm that this breaks the release.sh script. Had to manually fix this during the 0.18.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment