Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize adam-main cli from configuration file #918

Closed
heuermh opened this issue Jan 13, 2016 · 4 comments
Closed

Customize adam-main cli from configuration file #918

heuermh opened this issue Jan 13, 2016 · 4 comments

Comments

@heuermh
Copy link
Member

@heuermh heuermh commented Jan 13, 2016

No description provided.

@heuermh heuermh added this to the 0.20.0 milestone Feb 16, 2016
@fnothaft
Copy link
Member

@fnothaft fnothaft commented May 18, 2016

@heuermh what exactly where your thoughts on this? Like, the user would provide a manifest with classnames that would be populated into adam-main? Some sort of dependency injection system? For now, I think we should punt on this as out of scope.

@heuermh
Copy link
Member Author

@heuermh heuermh commented May 18, 2016

We already have dependency injection, someone said this during a meeting or call so I added an enhancement request for it. Fine to bump until later.

@heuermh heuermh removed this from the 0.20.0 milestone May 18, 2016
@fnothaft
Copy link
Member

@fnothaft fnothaft commented May 18, 2016

SGTM!

@fnothaft
Copy link
Member

@fnothaft fnothaft commented Mar 3, 2017

We haven't had another request for this in the last 9 months. @heuermh please reopen if you think we should support it.

@fnothaft fnothaft closed this Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.